[Compcomm] Animation plugin, minimize trigger

[Sam Spilsbury]

Yep. cool.

Remember what I said about having most animations go to the taskbar when
minimized (Like glide 2, dream,curved and horizontal fold etc)

On 5/8/07, Erkin Bahceci <erkinbah at gmail.com> wrote:
>
> Sending to composite community list as well.
>
> > On 5/7/07, Danny Baumann <dannybaumann at web.de> wrote:
> > > Hi,
> > >
> > > I just wanted to tell you that this commit:
> > >
> > >
> http://gitweb.opencompositing.org/?p=compcomm/plugins/animation;a=commitdiff;h=17732f2b17663836473db65b28650dd7944c0a3e
> > >
> > > is wrong IMO.
> > > With this one, the minimize animation is always triggered whenever a
> > > window in whatever way. This does not only include minimization and
> > > hiding for showdesktop mode, but also normal window hiding. The
> problem
> > > here is that for example the hiding of the switcher window will be
> > > animated when the switcher is terminated; which clearly is not
> desired.
> > > I know what you want to achieve (having the animation when entering
> > > showdesktop mode, right?), but in my opinion this is not the right way
> > > to achieve this. Instead, we should have a minimize-to-desktop plugin
> > > for that.
> > > BTW: The problem I just described was the reason why I changed the
> check
> > > to w->minimized in the first place ;-)
> > >
> > > Regards,
> > >
> > > Danny
>
> On 5/7/07, Erkin Bahceci <erkinbah at gmail.com> wrote:
> > Hi,
> >
> > On 5/7/07, Danny Baumann <dannybaumann at web.de> wrote:
> > > Hi,
> > >
> > > > I realized the problem with switcher yesterday. I had forgotten
> about
> > > > your change in the past. I was trying to do the minimization the
> same
> > > > way as the Minimize plugin does (it uses !w->invisible if you have a
> > > > look at it).
> > >
> > > Oh, I never realized minimize.c does the same ... maybe we should ask
> > > David about that? The match used by minimize is the same ... from a
> > > quick look at the code what animation.c does should be fine, too -
> > > although I still think w->minimized should be the trigger for the
> > > _minimize_ event (I even would consider the usage of !w->invisible a
> bug
> > > in minimize.c) ;-)
> >
> > Do you want to bug David about it?
> >
> > > > I think Animation should act similar to Minimize for the
> > > > minimization event. Clearly I'm missing something that Minimize does
> > > > or doesn't do. I'll have a look into that tonight. Do you have any
> > > > idea about what I'm missing or about another way to achieve
> > > > minimize-all on "show desktop"?
> > >
> > > "Minimize-to-desktop" plugin ;-)
> >
> > :) Still, I don't think we need another plugin for something so small.
> >
> > >
> > > BTW: Are you already working on completely porting animation to the
> > > metadata system? If no, are you ok with me doing it?
> > >
> >
> > I couldn't start doing that because of lack of time. Heck, it was a
> > busy semester :)
> > If you want to go ahead and do it, that's ok with me. Btw, what is it
> > with the 3rd field of the CompMetadataOptionInfo structure? Why do we
> > only give <min> for float, and <min>&<max > for int, and nothing for
> > string? Such as:
> >
> > +    { "friction", "float", "<min>0.1</min>", 0, 0 },
> > +    { "spring_k", "float", "<min>0.1</min>", 0, 0 },
> > +    { "grid_resolution", "int", "<min>1</min><max>64</max>", 0, 0 },
> > +    { "min_grid_size", "int", "<min>4</min><max>128</max", 0, 0 },
> > +    { "map_effect", "string", 0, 0, 0 },
> >
>
> Ok, I found the cause of the problem. Minimize plugin has this
> condition to animate minimization:
>    minGetWindowIconGeometry (w, &mw->icon)
>
> while Animation doesn't, because I'm animating minimization of windows
> even when there is no window list applet (they minimize toward
> bottom-middle). Minimize plugin doesn't animate minimization in that
> case. The question is, is there a good way to distinguish the
> minimization cases such that
>
> - show-desktop minimizes all windows.
> - switcher window and other "hidden windows" don't get animated as
> minimization.
> - when there is no window list applet (or no window icon geometry),
> windows minimize toward bottom-middle (do we still want to do this
> btw?)
>
> If we drop the 3rd requirement, everything would be fine (since then I
> can do minimization initiation like Minimize plugin does). What do you
> think?
>
> Cheers,
> Erkin
> _______________________________________________
> CompComm mailing list
> CompComm at Rock3d.org
> http://www.ubaight.com/mailman/listinfo/compcomm
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.RiverGorgeSolutions.net/pipermail/compcomm/attachments/20070508/a7ce0463/attachment-0001.htm>